Simon André
Simon André
Agree with @kbond ! Yes to the idea, but let’s take some time before exposing anything, as the next week could require some changes in the implementation.
You did not answer my comment: https://github.com/symfony/ux/issues/1387#issuecomment-1888028137 On my test it worked well ... could you update your message to show a concrete example of something that did not work...
> Hey @smnandre your example works because you set a default value to your props, remove the default value and you should have an error Ok thanks, indeed it triggers...
It's only for props not defined in the php class, right ?
I made some tries, and there is a little case that make me 🤔 If your component class contains properties without default values, props from the container seems to override...
Last question, the DX could be improved i think in case of ignored props... Maybe we could throw an exception/error, as the developper may not understand why its props "does...
> Hummmm, I am not sure about that I like the current behavior it sounds more obvious to me. But maybe we should trigger an error if props with the...
I'm wondering if we're not creating some confusion between "props" (things that can be passed from the calling template) and their default values (when they are not passed from the...
Really like this choice, allowing us to move this forward while not closing the door at future improvments. Do you want a last "proofread" on this PR ?
Minor thing, i'd suggest a change for the exception message, as * i think it's better if we can explicitely identify template and class * i kinda imagine either it'smore...