evm.codes icon indicating copy to clipboard operation
evm.codes copied to clipboard

feat: add opcode search actions in kbar component

Open SouravInsights opened this issue 2 years ago • 8 comments

The easiest way to add opcode navigation to the kbd component is by manually adding individual actions for each opcode in the useActions lib but obviously, it is a cumbersome task to do it manually.

I'll soon think about the easiest way to achieve this.

But here's a demo of the current working implementation: https://user-images.githubusercontent.com/26466468/177504643-becf42d6-a903-49de-8e1d-683c9623b896.mp4

SouravInsights avatar Jul 06 '22 08:07 SouravInsights

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
evm-codes ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 5:28PM (UTC)

vercel[bot] avatar Jul 06 '22 08:07 vercel[bot]

Yep, that is a bit tedious, we will stay tuned and thanks so much for contributing.

dorlevi avatar Jul 08 '22 01:07 dorlevi

Hey, @dorlevi 👋

This implementation works but in a weird way. At the first render when you select the Search Opcodes options it doesn't work but if you forcefully try to rerender the component by making a random change in the rootSearchAction variable within useOpcodesActions.tsx file, it works fine.

Can you please take a look? Let me know if it doesn't make sense.

Also tagging @peroket @ArthurBraud @assimovt

SouravInsights avatar Jul 13 '22 17:07 SouravInsights

hi @SouravInsights, checked the preview branch and can't get the search to work

dorlevi avatar Jul 20 '22 12:07 dorlevi

hi @SouravInsights, checked the preview branch and can't get the search to work

Did you try making a random change in the rootSearchAction variable within useOpcodesActions.tsx file?

Here's a demo video for your reference!

Let me know if it still doesn't work. @dorlevi

SouravInsights avatar Jul 21 '22 16:07 SouravInsights

hey, @dorlevi did it work for you?

SouravInsights avatar Jul 27 '22 12:07 SouravInsights

I haven't tried, I watched the video and believe it works if you do that but no user would do that! We are currently short on FE resources when we alleviate that we can fix and merge but we can't merge at the current state.

dorlevi avatar Jul 28 '22 13:07 dorlevi

Yeah yeah of course, no user would do that. I'll figure out why that is happening & put up a fix soon.

SouravInsights avatar Jul 28 '22 14:07 SouravInsights

Since there was no update on this in a long while, I'm closing the PR, but we would be happy to get that change if you have some time :-)

peroket avatar May 15 '23 07:05 peroket