Jonas Strittmatter

Unfortunately, it's significantly slower than without caching `find` :smile: | | Time in s | %-change | |----------------------------------|-----------|-----------| | Before this PR | 12.63 | | | global `env_patterns` table...

I have updated the results, seems like not using a metatable really was a good idea :D

> Does this include the separate pattern_env table that is expanded unconditionally? (Hard to tell from the table.) Using that, there is no noticeable slowdown. A disadvantage is that users...

> In vim.filetype.add you could just add it to the pattern_env table if the pattern contains a ${SOME_VAR}. Done. Btw, how can priorities be handled with that approach or do...

> Have you used lspsaga's diagnostic yet I haven't, thank you - that looks really nice! > I think it is showing the behavior of the diagnosis and not the...

Hey @weilbith, hope you're doing well :) I just thought I'd ping you regarding this PR in case you missed the GitHub notification. I understand if you're busy though, so...

No worries at all! That error is actually expected if the LSP server hasn't started up yet. I don't know if it would be best to increase the timeout specifically...

Seems like a nice feature to have! Did I understand you correctly that this preview window should be shown as a sort of confirmation dialog when you press enter? And...

Hey @pidgeon777, are you still interested in this feature?

> At least for the current file, this is already possible. See `:h command-preview`: Since https://github.com/neovim/neovim/pull/19360 the command preview does work across multiple files. > You should probably return `2`...