smithy icon indicating copy to clipboard operation
smithy copied to clipboard

Smithy logo is cut off in new docs website in Firefox

Open david-perez opened this issue 2 years ago • 4 comments

Both the v1 and v2 doc websites exhibit this behavior. I can't reproduce in Chromium.

image

david-perez avatar Aug 17 '22 10:08 david-perez

Thanks for reporting. I'm unable to reproduce this behavior, I'll need some more information about your environment. What is your operating system, and what is the Firefox version?

milesziemer avatar Aug 17 '22 15:08 milesziemer

Firefox 103.0 on Ubuntu 18.04.6.

david-perez avatar Aug 17 '22 17:08 david-perez

I can reproduce with Firefox 104.0.1 on Ubuntu 22.04 too.

david-perez avatar Sep 03 '22 20:09 david-perez

Reproducible with FF on 20.04.

The preferred font Open Sans is not installed (seemingly by default), so Firefox ends up choosing DejaVu Sans as sans-serif for the SVG and both the overall width and weight of the text is affected. Chrome, for me, chooses Liberation Sans for sans-serif, which just so happens to fit within the viewbox.

Installed fonts-open-sans and the logo then appeared similar to Chrome. Removed it, and the logo was again distorted and cut off.

For something as visually-critical as a logo seems like we wouldn't want to rely on users having the right fonts. We could keep using an SVG version of this logo if we convert the text to a path instead. The logo looks like it could also use some cleanup regarding the hammer - it's a raster image, but is a simple shape and looks straightforward to turn into a path. Or just go full raster with the logo for browser usage (doesn't seem to exist in the repo yet). :shrug:

jffrenc avatar Feb 14 '23 13:02 jffrenc