smithy-rs icon indicating copy to clipboard operation
smithy-rs copied to clipboard

Published 20 hours ago • verified publisher icon smithy-lang

Deny warnings in generated crates

Open david-perez opened this issue 1 year ago • 2 comments

We already --deny warnings in:

  • integration tests (crates generated by the codegen-{core,client,server}-test Gradle subprojects),
  • {client,server}IntegrationTests; and
  • RustWriter.compileAndTest, via the RUSTFLAGS we bake in the CI Docker image (note though that we should delete usages of RustWriter.compileAndTest https://github.com/smithy-lang/smithy-rs/issues/3193).

However, we do not deny warnings in TestWriterDelegator.compileAndTest; we generate crates with tests that have warnings.

It seems worthwhile to modify the tests so that they don't generate warnings to be consistent across the board. If a test can't be modified so as not to emit warnings, that specific test should opt-in into allowing warnings.

david-perez avatar Nov 14 '23 15:11 david-perez