mzLib icon indicating copy to clipboard operation
mzLib copied to clipboard

FlashLFQ refactoring to enable generic peak operations

Open Alexander-Sol opened this issue 1 year ago • 1 comments

Added an interface, ISingleScanDatum and and abstract class, TraceablePeak, to enable the generic use of pre-existing FlashLFQ functions.

ISingleScanDatum

  • Defines the behaviour that a single datapoint is expected to have, e.g., mz, index, separation (retention time)
  • Examples are IndexedMassSpectralPeak, IsotopicEnvelope

TraceablePeak

  • Contains a list of ISingleScanDatum object
  • Implements a default CutPeak method
  • Provides a static FindPeakBoundaries method that should be useful

Alexander-Sol avatar Feb 13 '25 22:02 Alexander-Sol

Codecov Report

Attention: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (e4dda42) to head (2711f04).

Files with missing lines Patch % Lines
mzLib/FlashLFQ/Interfaces/TraceablePeak.cs 90.19% 4 Missing and 1 partial :warning:
mzLib/FlashLFQ/IndexedMassSpectralPeak.cs 66.66% 2 Missing :warning:
mzLib/FlashLFQ/ChromatographicPeak.cs 96.00% 0 Missing and 1 partial :warning:
mzLib/FlashLFQ/IsotopicEnvelope.cs 66.66% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   77.78%   77.77%   -0.02%     
==========================================
  Files         230      231       +1     
  Lines       34152    34170      +18     
  Branches     3538     3540       +2     
==========================================
+ Hits        26566    26576      +10     
- Misses       6983     6990       +7     
- Partials      603      604       +1     
Files with missing lines Coverage Δ
mzLib/FlashLFQ/FlashLfqEngine.cs 92.18% <100.00%> (-0.29%) :arrow_down:
mzLib/FlashLFQ/ChromatographicPeak.cs 97.90% <96.00%> (-0.39%) :arrow_down:
mzLib/FlashLFQ/IsotopicEnvelope.cs 81.48% <66.66%> (-1.86%) :arrow_down:
mzLib/FlashLFQ/IndexedMassSpectralPeak.cs 92.00% <66.66%> (-8.00%) :arrow_down:
mzLib/FlashLFQ/Interfaces/TraceablePeak.cs 90.19% <90.19%> (ø)

codecov[bot] avatar Feb 14 '25 00:02 codecov[bot]