mzLib icon indicating copy to clipboard operation
mzLib copied to clipboard

Issue with Write method in Readers

Open Alexander-Sol opened this issue 5 months ago • 1 comments

In Readers, the WriteResults methods calls CanRead to validate a file path.

CanRead checks the intended output path for a given file extension from SupportedFileType. However, these types contain specific text that helps to identify which software generated the file.

If you're trying to write to a file that's named differently from the input file, it will be modified. (e.g., for MsFraggerPeptide, a file path of "FraggerPeptideCopy.tsv" would be modified to "FraggerPeptideCopy.tsvpeptide.tsv")

I don't think this is the intended behaviour. CanRead should probably check the extension by call GetExtension, and modify by stripping the existing extension and replacing it.

Alexander-Sol avatar Sep 13 '24 17:09 Alexander-Sol