mzLib icon indicating copy to clipboard operation
mzLib copied to clipboard

Modification TerminusLocalization enum was easier to use

Open acesnik opened this issue 6 years ago • 2 comments

The new switch-case based on exact string matching is much easier to mess up than an enum with several constant values.

https://github.com/smith-chem-wisc/mzLib/blob/master/Proteomics/Modifications/Modification.cs#L98

acesnik avatar Sep 05 '18 03:09 acesnik

I'm having to copy-paste from mzLib code to get it right, which shouldn't be necessary.

acesnik avatar Sep 05 '18 03:09 acesnik

👍

rmillikin avatar Sep 05 '18 14:09 rmillikin