MetaMorpheus icon indicating copy to clipboard operation
MetaMorpheus copied to clipboard

[Ignore Coverage] #4 - Digestion params generalization

Open nbollis opened this issue 1 year ago • 2 comments

Generalizes digestion parameters in common parameters to enable rna digestion and protein digestion.

In the task windows, I had to move all things dependent upon the digestion agent being a protease into an if clause that casts the IDigestionParams.DigestionAgent into a protease

Needed to improve code coverage so I found a few miscelaneous spots to do so. ModTypeForTreeViewModel and the Glyco Node class

nbollis avatar Feb 09 '24 00:02 nbollis

Codecov Report

Attention: Patch coverage is 87.78626% with 16 lines in your changes missing coverage. Please review.

Project coverage is 93.00%. Comparing base (4a0a5e8) to head (1ed889e). Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   92.79%   93.00%   +0.20%     
==========================================
  Files         137      137              
  Lines       21170    21172       +2     
  Branches     2924     2935      +11     
==========================================
+ Hits        19645    19691      +46     
+ Misses       1045      998      -47     
- Partials      480      483       +3     
Files Coverage Δ
MetaMorpheus/EngineLayer/CommonParameters.cs 95.28% <100.00%> (-0.24%) :arrow_down:
...gineLayer/CrosslinkSearch/CrosslinkSearchEngine.cs 91.10% <100.00%> (+0.01%) :arrow_up:
...pheus/EngineLayer/FdrAnalysis/FdrAnalysisEngine.cs 96.50% <100.00%> (ø)
...EngineLayer/FdrAnalysis/PEPValueAnalysisGeneric.cs 96.10% <100.00%> (ø)
MetaMorpheus/EngineLayer/GlycoSearch/Node.cs 88.00% <ø> (+21.33%) :arrow_up:
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 87.47% <100.00%> (ø)
...neLayer/ProteinParsimony/ProteinParsimonyEngine.cs 98.83% <100.00%> (ø)
MetaMorpheus/EngineLayer/Silac/SilacConversions.cs 97.83% <ø> (ø)
MetaMorpheus/EngineLayer/SpectralMatch.cs 99.71% <100.00%> (ø)
...GuiFunctions/ViewModels/ModTypeForTreeViewModel.cs 100.00% <100.00%> (+48.00%) :arrow_up:
... and 13 more

... and 1 file with indirect coverage changes

codecov[bot] avatar Feb 14 '24 18:02 codecov[bot]

wherein nic embraces the var side

trishorts avatar Mar 07 '24 21:03 trishorts