MetaMorpheus
MetaMorpheus copied to clipboard
[WIP] Calibration bug fix
Failure to calibrate one file in a list of files leaves the tolerances of common params adjusted too wide for the subsequent scan. This PR changes the code to use a local copy of common params for each calibrated file that is created anew for each separate file.
Also using this opportunity to substitute explicit variables for var and to update code with discards, which showed up in C# 7 https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/functional/discards
Codecov Report
Merging #2135 (ef1dbd4) into master (341d25e) will increase coverage by
0.09%
. The diff coverage is91.11%
.
@@ Coverage Diff @@
## master #2135 +/- ##
==========================================
+ Coverage 90.91% 91.00% +0.09%
==========================================
Files 133 133
Lines 19999 19999
Branches 2772 2772
==========================================
+ Hits 18183 18201 +18
+ Misses 1311 1297 -14
+ Partials 505 501 -4
Impacted Files | Coverage Δ | |
---|---|---|
EngineLayer/ExperimentalDesign.cs | 100.00% <ø> (+10.28%) |
:arrow_up: |
TaskLayer/MyTaskResults.cs | 100.00% <ø> (ø) |
|
TaskLayer/CalibrationTask/CalibrationTask.cs | 89.14% <91.11%> (+3.16%) |
:arrow_up: |