MetaMorpheus icon indicating copy to clipboard operation
MetaMorpheus copied to clipboard

Published 20 hours ago • verified publisher icon smith-chem-wisc

Restructure base directory

Open acesnik opened this issue 3 years ago • 4 comments

https://github.com/smith-chem-wisc/MetaMorpheus/issues/1956

acesnik avatar May 18 '21 12:05 acesnik

This PR aims to clean up the GitHub landing page by simplifying the base directory.

  • Most people find MetaMorpheus through the GitHub landing page, rather than the .github.io landing page, so simplifying the GitHub landing page may be helpful for first-time navigation of the site: image

Before -- current GitHub landing page: image

After: image

acesnik avatar May 18 '21 12:05 acesnik

NEAT! Build failed, tho :(

zrolfs avatar May 18 '21 12:05 zrolfs

The AppVeyor, Jenkins, and Docker build scripts would need to be updated, since the MetaMorpheus.sln changed location. I guess I don't want to change that before we decide this is something we want to do.

acesnik avatar May 18 '21 13:05 acesnik

I think this may be something to do after changing over to Github Actions, since it will be straightforward to change the locations of the solution file and such within the workflow. https://github.com/smith-chem-wisc/MetaMorpheus/pull/2128

Going to take off the 'final review' label for now.

acesnik avatar Mar 19 '22 01:03 acesnik

Looking for a quick double-check that this is okay to merge, since the approval reviews are quite old. This is ready for merge after amending AppVeyor build and test scripts.

acesnik avatar Mar 09 '23 03:03 acesnik

Concerns about git blame annotations

It sounds like the git blame annotations were messed up by the mzLib restructuring at some point, but from what I see in GitHub and Visual Studio 2022, that doesn't look to be the case anymore, and the blame looks informative:

Visual Studio 2022

image (29)

GitHub, Mar 2023

image (28)

acesnik avatar Mar 09 '23 19:03 acesnik

This restructure makes it very difficult to compare past commits to future commits. Git will list all pre-restructure files as "Deleted", and all post-restructure files as "Added." As such, direct comparison can't be done in Visual Studio. We ran into this issue with the mzLib restructure.

That being said, I think it's probably worth it to make the github page more user friendly.

Alexander-Sol avatar Mar 09 '23 21:03 Alexander-Sol

Cool, understood! Feel free to make a decision on your side and either merge or close this PR.

acesnik avatar Mar 09 '23 21:03 acesnik