smf icon indicating copy to clipboard operation
smf copied to clipboard

revisit exception safety

Open emaxerrno opened this issue 8 years ago • 2 comments

We are breaking some laws regarding exception safety.

see all the noexcept methods for instances.

emaxerrno avatar Mar 16 '17 15:03 emaxerrno

basically 2 things.

To prevent allocations either use a union {} or a pointer std::unique_ptr or seastar::lw_shared_ptr

that's it.

emaxerrno avatar Jun 13 '17 17:06 emaxerrno

clang-tidy warns for this too. so all the superficial bugs were fixed.

emaxerrno avatar Dec 04 '17 19:12 emaxerrno