Siyao Meng

Results 24 comments of Siyao Meng

Thanks @symious for the patch. There's another patch causing minor conflicts. Would you merge latest master to the PR branch again? I have resolved the conflict on my branch (I...

> @smengcl Do you have any suggestions on the failed unit test? The failure looks related at a first glance: https://github.com/apache/ozone/runs/8008158105 ```bash Error: org.apache.hadoop.ozone.recon.recovery.TestReconOmMetadataManagerImpl.testUpdateOmDB Time elapsed: 0.249 s

Thanks @symious for the patch. Thanks @adoroszlai for the review.

Merged. Thanks @xBis7 for the work! Thanks @GeorgeJahad and @dombizita for the review.

The Disk Usage page is throwing errors when the cluster is empty on my side. @smitajoshi12 Would you check if this is the case on your docker cluster (when empty)...

@errose28 Would you resolve the conflict and address the comments?

> cc @smengcl should we try to get this PR to a closure? cc @GeorgeJahad you can take the commits and start a new PR if you would like to....

> This is in response to the discussion here: [#3786 (comment)](https://github.com/apache/ozone/pull/3786#discussion_r992935645) > > To me there is value in the conceptual simplicity of having all the state in rocksdb. >...

This PR is ready for another round of review. UT `TestRocksDBCheckpointDiffer` output for reference: ``` 2022-11-01 22:22:44,258 [main] INFO rocksdiff.TestRocksDBCheckpointDiffer (TestRocksDBCheckpointDiffer.java:diffAllSnapshots(170)) - SST diff from 'rocksdb-cp-250000' to 'rocksdb-cp-1': [000013, 000022,...