unimported icon indicating copy to clipboard operation
unimported copied to clipboard

feat: add regex path transformation

Open chasingmaxwell opened this issue 3 years ago • 5 comments

This is useful for TypeScript projects outputing pure ESM.

See https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#how-can-i-make-my-typescript-project-output-esm.

Closes #66.

chasingmaxwell avatar Dec 29 '21 21:12 chasingmaxwell

Looks like the PR checks are failing in the same way the main branch on my local did. I think it's an issue with the TypeScript version range. When I pin it to the exact version specified in package.json it passes. I can work on fixing that as part of my PR, or if you would prefer I could fix in a separate branch/PR since it doesn't have anything to do with my pathTransforms change.

chasingmaxwell avatar Dec 30 '21 19:12 chasingmaxwell

Here's a PR to fix the test failures I was seeing on the main branch: https://github.com/smeijer/unimported/pull/69

chasingmaxwell avatar Jan 24 '22 19:01 chasingmaxwell

Support remix

Zaram22 avatar Feb 18 '22 04:02 Zaram22

#69

Zaram22 avatar Feb 18 '22 04:02 Zaram22

Hi, is there anything stopping this from being merged? We just recently migrated our typescript codebase to ESM and just noticed now that this tool had some issues with the new file imports. Seems like this PR fixes that issue so it would be amazing to get it merged

AnotherHermit avatar Aug 26 '22 06:08 AnotherHermit

Is there any progress on this PR?

Onimishra avatar Oct 28 '22 08:10 Onimishra

As far as I know this is still good to go. There are no conflicts with the base branch. It just needs to be reviewed and merged.

chasingmaxwell avatar Oct 28 '22 18:10 chasingmaxwell

Thanks! I've merged it. Sorry it took me so long.

I've also added you as a collaborator on the project. Please continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want.

Thanks again! Much appreciated. :heart:

smeijer avatar Nov 15 '22 22:11 smeijer

:tada: This PR is included in version 1.23.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

smeijer avatar Nov 15 '22 22:11 smeijer