docker-alpine icon indicating copy to clipboard operation
docker-alpine copied to clipboard

Published 20 hours ago • verified publisher icon smebberson

#12

Open matthewvalimaki opened this issue 8 years ago • 4 comments

  • Add missing nodejs user and group.
  • Updated examples to use nodejs user for execution.
  • Smaller cleanups.

Signed-off-by: Matthew Valimaki [email protected]

matthewvalimaki avatar Mar 23 '16 16:03 matthewvalimaki

@matthewvalimaki, are you able to refactor this PR now that all the changes have been launched? I still think it's a worth while addition.

smebberson avatar Jun 09 '16 23:06 smebberson

@smebberson yes sir. I'll try to get it done asap. On Jun 9, 2016 4:31 PM, "Scott Mebberson" [email protected] wrote:

@matthewvalimaki https://github.com/matthewvalimaki, are you able to refactor this PR now that all the changes have been launched? I still think it's a worth while addition.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/smebberson/docker-alpine/pull/33#issuecomment-225056804, or mute the thread https://github.com/notifications/unsubscribe/AA_GtTes6VeGI1Rs-1KGrMMSsmQv6C_6ks5qKKJhgaJpZM4H3NeZ .

matthewvalimaki avatar Jun 09 '16 23:06 matthewvalimaki

@matthewvalimaki, I'm going to be making these changes while moving to Node.js v7. I'm going to be releasing all of the 6.x releases I've missed now. Are you willing to refactor this now as there has been a few changes, and then I'll merge this in.

Thanks!

smebberson avatar Oct 29 '16 21:10 smebberson

@smebberson I am looking for a way operate within the container as non-root user. Since this PR seems outdated – can you recommend any best practices for now?

/cc @GauSim

benedikt-roth avatar Apr 17 '18 08:04 benedikt-roth