Steven van Beelen

Results 319 comments of Steven van Beelen

Closing this issue due to inactivity. Be sure to reach out to us @unisteven if the problem still persists after the explanation above! In that case, we will reopen the...

First and foremost, thanks for making an effort to provide a pull request, @jvanheesch! I have taken some time to go over this pull request and its description. Based on...

You've gone the stretch to construct a pull request with a very thorough explanation (which is very helpful). Although on the 12th of January, I pointed out I was rather...

Welcome back, @timtebeek! Although these are minor wins and not overly important for the inner workings of Axon Framework, I am very much into aligning the code base with standards....

The use of `String#format` can definitely go. If anything, that's POV from long ago or contributions; so no "religious" desire to have it that way. But, the last one "seems"...

Awesome, I learned something new today! Thanks for the eye-opener, @timtebeek. And agreed, running `ParameterizedLogging` and `Slf4jLogShouldBeConstant` makes sense.

Welcome, @hjohn, and thanks for providing an enhancement suggestion with us. > I'm evaluating Axon at the moment, and the GapAwareTrackingToken doesn't quite feel right to me. Although I wouldn't...

I did some digging (read: asked the repository owner) whether they had ever considered doing this in the past. As it turns out, they did for Axon Framework 2 but...

Given the required (and desired) uniqueness of the indices, I think we can conclude the the initial suggestion is not generic enough a solution to provide for Axon Framework. If...

That's some amazing effort you've put in, @hjohn. Thank you very much :muscle: This test you've run, is that perhaps a shareable repository for us/others to view? Although the textual...