Products.PloneFormGen icon indicating copy to clipboard operation
Products.PloneFormGen copied to clipboard

stringValidators (such as "This is not a valid email address.") in config.py are not translated

Open frisi opened this issue 10 years ago • 2 comments

validation error messages such as This is not a valid email address. are not translated at all.

the errid ( (eg pfg_isEmail) are not included in the po files. (the i18nids are not used at all - at least not for translating the messages - and can probably be removed by also removing them in FormGenTool)

probably we'll need to add them manually to a separate po file and merge this one in rebuild_i18n.sh

something like this should do it

/opt/python/python-2.6/bin/i18ndude rebuild-pot --pot locales/${PRODUCTNAME}.pot --merge locales/manual.pot --create ${I18NDOMAIN} .

manual.pt would need to contain the errid values (note that using the i18nid such as vocabulary_isemailaddress_text does not work):

#. Default: "This is not a valid email address."
#: ./config
msgid "pfg_isEmail"
msgstr ""

unfortunately theses strings need to be re-translated for every language. maybe we can find them in an earlier pfg release?

btw: the i18n directory seems to hold plone translations needed in templates such as skins/fg_edit_macros_p3.pt. is this bbb stuff needed in the 1.7 release?

frisi avatar Sep 25 '14 11:09 frisi

See https://github.com/FHNW/Products.PloneFormGen/commit/efef5aadc287c44036305bd1e8136ac58ed3d603

tomgross avatar Nov 03 '14 11:11 tomgross

thanks @tomgross - looks promising. any reason you did not create a PR for this?

frisi avatar Nov 04 '14 16:11 frisi