loggr icon indicating copy to clipboard operation
loggr copied to clipboard

Option vs environment

Open richfitz opened this issue 10 years ago • 3 comments

Any reason for using options / getOption to store the global state and not a package environment? I feel like the latter is more typical and is generally easier to work with.

This is probably just a stylistic difference, though I feel that the semantics around the two differ (options users are allowed to poke with, environments are package internals).

Again, happy to work up a PR with this, as it's a really straightforward change. There would be no user-visible differences.

richfitz avatar May 23 '15 01:05 richfitz

I am not sure I have a strong opinion about this.

smbache avatar May 23 '15 09:05 smbache

Do you have a prefererence to change this?

smbache avatar Jul 07 '15 18:07 smbache

I think I'd prefer an environment. I can contribute the change if you're happy with it being changed, otherwise if you'd rather keep it as done via options, just close this.

richfitz avatar Jul 07 '15 22:07 richfitz