merge-conflicts icon indicating copy to clipboard operation
merge-conflicts copied to clipboard

Function.extractParams is deprecated.

Open coolamit1240 opened this issue 8 years ago • 23 comments
trafficstars

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/opt/atom/resources/app.asar/src/text-editor.js:1753:38)
ConflictVisitor.markSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:308:38)
ConflictVisitor.visitTheirSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:301:29)

coolamit1240 avatar Mar 07 '17 05:03 coolamit1240

+1

bhushangahire avatar Mar 14 '17 18:03 bhushangahire

Me two +1

ItamarGronich avatar Mar 15 '17 17:03 ItamarGronich

+1

danfoley avatar Mar 16 '17 16:03 danfoley

+1

jasondibenedetto avatar Mar 17 '17 02:03 jasondibenedetto

+1

amoghesturi avatar Mar 17 '17 11:03 amoghesturi

+1

fh250250 avatar Mar 20 '17 09:03 fh250250

+1

g0ody avatar Mar 20 '17 11:03 g0ody

+1

jurmarcus avatar Mar 22 '17 21:03 jurmarcus

+1

deemco avatar Mar 23 '17 09:03 deemco

+1

patrickml avatar Mar 23 '17 17:03 patrickml

+1

ibcWillJust42 avatar Mar 24 '17 07:03 ibcWillJust42

+1

Andor-Z avatar Mar 26 '17 08:03 Andor-Z

+1

criswilk avatar Mar 29 '17 00:03 criswilk

+1

erasmus avatar Apr 03 '17 10:04 erasmus

+1

timfallmk avatar Apr 04 '17 18:04 timfallmk

+1

enygmatik avatar Apr 21 '17 15:04 enygmatik

+1

HermanBergner avatar Apr 25 '17 12:04 HermanBergner

+1

Nrohtgnohp avatar Apr 26 '17 04:04 Nrohtgnohp

+1

shillem avatar May 08 '17 19:05 shillem

+1

iknowmac avatar May 09 '17 13:05 iknowmac

Instead of just adding "+1" (did you know you can just thumbsup the first message ?) until the end of time, does anyone understand the issue/have an idea of how to fix this ?

pichouk avatar May 09 '17 13:05 pichouk

@pichouk I think the suggested solution was in the first message of this issue. I just don't see any movement on this repo.

timfallmk avatar May 10 '17 17:05 timfallmk

This was actually fixed in smashwilson/merge-conflicts#265, I just, uh, never actually did the release. 😅 I just pushed 1.4.5 with that PR merged, but completely untested because, as some of you have noticed:

I just don't see any movement on this repo.

:sparkles: This repository is being deprecated :sparkles:

The full announcement is there, but the short version is that there's a better core package now that eclipses the functionality in this one :grin:

smashwilson avatar May 16 '17 19:05 smashwilson