merge-conflicts icon indicating copy to clipboard operation
merge-conflicts copied to clipboard

Implement a "why" button

Open smashwilson opened this issue 10 years ago • 5 comments

This was actually one of the first ideas I'd had for this package, and for whatever reason I never got around to doing it, or writing it down.

On each conflict marker, I want to add a "Why" button. Pressing it presents you with a view that shows each commit that touched the conflict marker's diff on both sides of the merge, including the relevant diffs. That way, you can get some context about the specific conflict area was changed.

smashwilson avatar Apr 15 '15 13:04 smashwilson

It's sort of the same as the #9 no? I mean the three way merge is actually here to be able to compare to the origin.

malexandre avatar May 28 '15 12:05 malexandre

Oh, it is like an enhanced version of a three-way diff marker - I hadn't thought of that.

Diff3 markers show you the content from the common ancestor, while this would ideally show you each commit on both sides, including the commit messages and any other changes that were made at the same time. I've wanted this personally (and replicated it with a bunch of git log calls) to try to put the changes that introduced a specific conflict into context and figure out what the correct resolution is.

Supporting diff3 is far less work, so it would certainly be higher priority for me :smile: And it's quite possible that I won't want this as much once that's in place.

smashwilson avatar May 28 '15 12:05 smashwilson

:+1:, of course

dorian-marchal avatar Dec 08 '15 15:12 dorian-marchal

Is this still planned? I do love diff3 but I think a feature like this is even better.

axelson avatar Jun 17 '16 21:06 axelson

I certainly still think it'd be cool and useful :grin:

It is a big expansion of scope, though. It might be better to find (or write) a git log package that exposes a service and integrate with that.

With that being said: I work on this project in pretty short bursts, as time and energy permit, so I really don't want to raise hopes or commit to any sort of timeline :wink:

smashwilson avatar Jun 20 '16 15:06 smashwilson