smarty icon indicating copy to clipboard operation
smarty copied to clipboard

{$smarty.template} with "_" characters and custom resource

Open Scootin159 opened this issue 5 years ago • 5 comments

This is a followup to issue #490

The original report was that the {$smarty.template} variable reports incorrectly for template names that contain an underscore. After some further testing, I was able to isolate that the issue only happens when using a custom resource.

I've attached a sample which recreates the issue. To reduce the size of my upload, I didn't include the smarty installation, which is expected to be in a "smarty" sub directory.

example.zip

Scootin159 avatar Apr 08 '20 03:04 Scootin159

I've been able to isolate the issue to the following commit:

https://github.com/smarty-php/smarty/commit/614ad1f8b9b00086efc123e49b7bb8efbfa81b61

Scootin159 avatar Apr 08 '20 03:04 Scootin159

I have the issue resolved locally, but it appears as though I don't have permissions to push to this repository. Is there a different procedure, other than requesting permissions to push branches and open pull requests?

Scootin159 avatar Apr 08 '20 04:04 Scootin159

Hi @EDCScott! At github it is customary for you to fork this project in your own namespace, create a branch that fixes the issue there and than create a pull request (PR) from your repo to this one.

wisskid avatar Apr 10 '20 22:04 wisskid

Done. Thank you for the insight.

Scootin159 avatar Apr 13 '20 14:04 Scootin159

NIce! I'll review the PR asap.

wisskid avatar Apr 13 '20 14:04 wisskid

Fix was already merged last year.

wisskid avatar Jan 31 '23 10:01 wisskid