unused Entry and unnecessary entry

[mschoch]

I've been getting a deeper understanding of the code and found the following.

1. The type Entry defined in mintree.go does not appear to be used anywhere. It is defined here: https://github.com/smartystreets/mafsa/blob/1575156d598714bb1c41713191eefb7f5ccf3e8b/mintree.go#L26

2. The entry argument to decodeEdge(...) seems to serve no purpose. We only ever append to it and pass to recursive calls, but its never used for anything. Further, when I remove it, and all usage of it, all tests in the package continue to pass. See: https://github.com/smartystreets/mafsa/blob/1575156d598714bb1c41713191eefb7f5ccf3e8b/decoder.go#L85

Is this just left over from some previous version of the implementation? Or am I missing some key aspect of the way things are working?

[mdwhatcott]

You are probably correct in both observations above. This repository was pioneered almost exclusively as an R&D experiment by @mholt who is no longer with SmartyStreets. Not much has happened with the code since then, although there are a few open pull requests.