Ahmad Bitar

One more 

Possible flaky? 

LGTM. The locking is simple and solves any problem that could arise.

@smartprogrammer93 will check on eth_syncing and if it waits for the client to finish syncing @FalcoXYZ will check if we can submit information to gitbook through its api from the...

@LukaszRozmej not entirely sure which delegate is blocking the invocation. also, parallelizing the the delegate method could lead to its own problems in my opinion (with concurrency and race conditions)....

I will not merge this till it is properly tested and be sure it will resolve the issue. @kamilchodola waiting on your confirmation, as i am not sure how exactly...

@LukaszRozmej i disagree. since if another syncmode change happens while the handler is still executing the previous one it could lead to a race condition. With this approach, the parallel...

I believe the whole idea behind this issue and PR is obselete. It was in the early days of SnapSync when suddenly in the mainnet config snapsync became on by...

No mainnet config is still the default. Its just that all private network probably upgraded and adjusted to the change. The change to snapsync being on by default was introduced...

@asdacap what do you think about something like this: A hybrid approach till we switch everything bit by bit to utilize DI https://github.com/NethermindEth/nethermind/blob/refactor%2Fintroduce_dependency_injection/src%2FNethermind%2FNethermind.Api%2FNethermindApiCustomResolver%20.cs Dont mind the implementation, it could probably...