sdl_ios icon indicating copy to clipboard operation
sdl_ios copied to clipboard

Start updating RPCs with generated initializers

Open joeljfischer opened this issue 5 years ago • 1 comments

Fixes #1821

Risk

This PR makes minor API changes.

Testing Plan

  • [ ] I have verified that I have not introduced new warnings in this PR (or explain why below)
  • [ ] I have run the unit tests with this PR
  • [ ] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests updated for new and deprecated initializers

Core Tests

Example apps run

Core version / branch / commit hash / module tested against: Manticore (Core 6.1.1) HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.8.1)

Summary

This PR adds all generated initializers and deprecates many older initializers.

Changelog

Enhancements
  • Added RPC initializers generated by the RPC generator and deprecated old initializers.

Tasks Remaining:

  • [ ] Finish adding / deprecating all initializers
  • [ ] Fix deprecations in unit tests
  • [ ] Add new unit tests for new initializers

CLA

joeljfischer avatar Oct 20 '20 19:10 joeljfischer

Codecov Report

Merging #1824 (dda5341) into develop (361db38) will decrease coverage by 7.80%. The diff coverage is 3.32%.

@@             Coverage Diff             @@
##           develop    #1824      +/-   ##
===========================================
- Coverage    84.65%   76.84%   -7.81%     
===========================================
  Files          418      418              
  Lines        20971    23093    +2122     
===========================================
- Hits         17753    17746       -7     
- Misses        3218     5347    +2129     

codecov[bot] avatar Oct 28 '20 14:10 codecov[bot]