sdl_core icon indicating copy to clipboard operation
sdl_core copied to clipboard

Mismatch for mandatory parameter between MOBILE_API and HMI_API

Open drauhut1 opened this issue 8 years ago • 6 comments

There is a mismatch for the mandatory parameter between the MOBILE_API and the HMI_API for the following parameters:

  • distanceToManeuver
  • distanceToManeuverScale

The MOBILE_API is reflecting that these parameters are not mandatory, whereas the HMI_API reflects that they are mandatory.

drauhut1 avatar Nov 07 '17 09:11 drauhut1

Contributor priority is set Medium with reason: The issue is related to API.

aderiabin avatar Dec 01 '17 12:12 aderiabin

@jacobkeeler , would this be considered as a breaking change and would it be okay to fix this as bug?

robinmk avatar Sep 27 '18 13:09 robinmk

The issue is relevant on the current develop branch

Environment: Test script: https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2120 SDL build: https://github.com/smartdevicelink/sdl_core/tree/develop ( 891497b ) ATF: develop branch

HSavynetska avatar Nov 22 '19 12:11 HSavynetska

Closing since proposal was accepted and separate issue was submitted: https://github.com/smartdevicelink/rpc_spec/issues/227

jacobkeeler avatar Oct 06 '20 13:10 jacobkeeler

@jordynmackool, The issue has been reopened because it was not fixed within smartdevicelink/rpc_spec#227 proposal.

distanceToManeuver and distanceToManeuverScale parameters are still not mandatory in the Mobile API and mandatory in HMI API

Also please notice that the script for this issue is ready for Livio review.

GetmanetsIrina avatar Apr 06 '21 12:04 GetmanetsIrina

FYI this is still a breaking change if we want to change the mandatory values in the mobile api / RPC spec. The proposal does not mention changing those values either. The proposal only mentions a description update.

I believe the proposal requires a revision stating this will be a breaking change to the RPC Spec, and wont be able to complete its implementation until a major version change (Core 8.0).

Jack-Byrne avatar Apr 06 '21 13:04 Jack-Byrne