smartcontracts

Results 300 comments of smartcontracts

I guess this repo assumes that all contracts are using interfaces? I will probably just end up disabling `@inheritdoc` but interesting either way

> Semgrep found **6** [`sol-style-input-arg-fmt`](https://semgrep.dev/playground/r/8KTQNxJ/ethereum_optimism.sol-style-input-arg-fmt?utm_campaign=finding_notification&utm_medium=review_comment&utm_source=github&utm_content=rule) findings: > > * packages/contracts-bedrock/src/L2/SuperchainWETH.sol > > * [L34](https://github.com/ethereum-optimism/optimism/blob/55141fea07d87f3eb4d9f9ea633cfdafa947e51d/packages/contracts-bedrock/src/L2/SuperchainWETH.sol#L34) - [Triage](https://semgrep.dev/orgs/ethereum-optimism/findings/70973547) > * [L39](https://github.com/ethereum-optimism/optimism/blob/55141fea07d87f3eb4d9f9ea633cfdafa947e51d/packages/contracts-bedrock/src/L2/SuperchainWETH.sol#L39) - [Triage](https://semgrep.dev/orgs/ethereum-optimism/findings/70973546) > * [L44](https://github.com/ethereum-optimism/optimism/blob/55141fea07d87f3eb4d9f9ea633cfdafa947e51d/packages/contracts-bedrock/src/L2/SuperchainWETH.sol#L44) - [Triage](https://semgrep.dev/orgs/ethereum-optimism/findings/70973545) > * [L62](https://github.com/ethereum-optimism/optimism/blob/55141fea07d87f3eb4d9f9ea633cfdafa947e51d/packages/contracts-bedrock/src/L2/SuperchainWETH.sol#L62) -...

Yeah this would be great, we're looking to check for unused imports to keep things clean https://github.com/ethereum-optimism/optimism/issues/11806

Hi! Sorry for the delay here, could you rebase this PR? I'll get it merged once it's been rebased.

Hi, my apologies for the delay here. This was resolved in a different PR.

Hi, sorry for the delay here. This needs a rebase and the semver lock will need to be regenerated but I can merge once that's done.

/ci authorize 665cd5476c26f9ae7d6bbe1136b26e521ce0f06e

@samlaf looks like the semver snapshot needs to be regenerated but otherwise seems good!