hardhat-starter-kit icon indicating copy to clipboard operation
hardhat-starter-kit copied to clipboard

Add keepers example using function selector checkData

Open giovannidisiena opened this issue 2 years ago • 12 comments

This PR extends the KeepersCounter.sol contract to add example usage of function selectors as checkData.

Tested locally and on Kovan testnet using Upkeep IDs [2028, 2029, 2030].

Corresponding tests will skip if multiplierEnabled is set to "false" in helper-hardhat-config.js.

giovannidisiena avatar Dec 24 '21 20:12 giovannidisiena

Ooohhhh. I like the idea of using an example with a perforumData. @andrejrakic can you take a look?

PatrickAlphaC avatar Jan 10 '22 23:01 PatrickAlphaC

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

PatrickAlphaC avatar May 16 '22 12:05 PatrickAlphaC

Wait.... How did @rdotterer09 approve the PR?

PatrickAlphaC avatar May 31 '22 21:05 PatrickAlphaC

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

Not a problem @PatrickAlphaC, likewise apologies for the delay. Assume you just mean to update by rebase and resolve conflicts right?

Wait.... How did @rdotterer09 approve the PR?

Lol no idea

giovannidisiena avatar Jun 22 '22 15:06 giovannidisiena

Guys, I'm not a coder, or trader, just an investor, I'm slowly learning how to read this code business so I am no threat to you, please update me on the total I have in contract after conversion is completed, Thank You

rdotterer09 avatar Jun 22 '22 15:06 rdotterer09

Is important for you guys to know I have some of the contract addresses on two different hard wallets, some on Arculus and some on nano X

rdotterer09 avatar Jun 22 '22 15:06 rdotterer09

@rdotterer09 no worries, we found out anyone can approve PRs on github ahah.

PatrickAlphaC avatar Jun 23 '22 18:06 PatrickAlphaC

and @giovannidisiena, yes!

PatrickAlphaC avatar Jun 23 '22 18:06 PatrickAlphaC

Are you guys getting any closer to finishing this project? Just concerned about my losses in this lovely market crunch

rdotterer09 avatar Jun 23 '22 18:06 rdotterer09

Cool, should be ready for review now @PatrickAlphaC 😄

giovannidisiena avatar Jun 25 '22 11:06 giovannidisiena

thanks @giovannidisiena ! @andrejrakic can you please review

pappas999 avatar Jun 26 '22 23:06 pappas999

Thanks @andrejrakic! Sure, that makes complete sense. Maybe if the timestamp fulfils some condition provided by checkData then checkUpkeep can return some performData upon which to act. Did you have any ideas?

giovannidisiena avatar Jun 28 '22 15:06 giovannidisiena