hardhat-starter-kit icon indicating copy to clipboard operation
hardhat-starter-kit copied to clipboard

private_key to wallet_private_key

Open naman1402 opened this issue 1 year ago • 5 comments

Changed PRIVATE_KEY to WALLET_PRIVATE_KEY in .env.example to avoid confusions.

naman1402 avatar May 06 '23 07:05 naman1402

Kindly tag me, for feedback.

naman1402 avatar May 06 '23 07:05 naman1402

Hi @NamanMohnani , why do you want to update PRIVATE_KEY to WALLET_PRIVATE_KEY?

QingyangKong avatar May 07 '23 10:05 QingyangKong

Hello @QingyangKong , someone had this issue, and it caused confusion to differentiate it from other key. https://github.com/smartcontractkit/hardhat-starter-kit/issues/165#issuecomment-1537295956

naman1402 avatar May 07 '23 11:05 naman1402

Can you also check the config file and readme to update the name?

QingyangKong avatar May 11 '23 08:05 QingyangKong

hey @QingyangKong I just made another commit as per requirements. Kindly review and give me a feedback and merge, if possible.

naman1402 avatar May 12 '23 18:05 naman1402