foundry-starter-kit icon indicating copy to clipboard operation
foundry-starter-kit copied to clipboard

Published 20 hours ago • verified publisher icon smartcontractkit

Update makefile deploy-rinkeby

Open wk0 opened this issue 2 years ago • 5 comments

In .env.example, variable for etherscan api key is ETHERSCAN_KEY, while in the makefile it is ETHERSCAN_API_KEY. Adjust makefile to use ETHERSCAN_KEY so script can run using the key specified in the .env file

wk0 avatar Aug 05 '22 23:08 wk0

can alternatively change the .env file to use ETHERSCAN_KEY

wk0 avatar Aug 05 '22 23:08 wk0

Hmm, still had issue using the deploy rinkeby make script, but found this issue.

https://github.com/foundry-rs/foundry/issues/2435

wk0 avatar Aug 06 '22 00:08 wk0

but then you have to switch to using forge create rather than the deploy script, so disregard dc0d2f8

wk0 avatar Aug 06 '22 01:08 wk0

@wk0 is there any chance you are compiling via the new intermediate representation pipeline? Verification of Yul IR bytecode on Etherscan is not currently supported, so that can also cause you to run into issues.

giovannidisiena avatar Aug 06 '22 09:08 giovannidisiena

It looks like you took out the broadcast option, was that intentional?

PatrickAlphaC avatar Aug 13 '22 01:08 PatrickAlphaC