external-adapters-js icon indicating copy to clipboard operation
external-adapters-js copied to clipboard

Batching discovery & upgrade: cryptocompare, cmc, tradermade

Open bryanjowers opened this issue 4 years ago • 0 comments

We want to upgrade certain EAs to support batching capabilities to reduce the number of requests on the data provider API.

Batching allows us to combine multiple requests into a single request on the data provider. This is only made possible if the data provider's API supports a batch request (for example, requesting BTC-USD and BTC-ETH in a single request, rather than requesting separately in 2 API calls)

The task here is to review if these existing EAs and their API provider can support batching. Upgrade those that can support it.

Examples of EAs with batching support already implemented:

  • [x] cryptocompare https://github.com/smartcontractkit/external-adapters-js/tree/develop/packages/sources/cryptocompare
  • [x] coinmarketcap https://github.com/smartcontractkit/external-adapters-js/tree/develop/packages/sources/coinmarketcap
  • [x] tradermade https://github.com/smartcontractkit/external-adapters-js/tree/develop/packages/sources/tradermade

EAs that need checking: (please check those that can be upgraded based on API support):

  • [x] finage
  • [ ] dxfeed
  • [ ] kaiko
  • [ ] nomics

bryanjowers avatar Aug 03 '21 22:08 bryanjowers