external-adapters-js icon indicating copy to clipboard operation
external-adapters-js copied to clipboard

Use Overrider within ID enabled EAs

Open justinkaseman opened this issue 2 years ago • 1 comments

Description

External Adapters accept overrides as input parameters or as hardcoded configuration within the EA. These traditionally are used for symbol to symbol conversions when a data provider requires input that isn't the standard symbol. (e.g. BTC -> BITCOIN). Certain data providers accept queries using a currency's id or cid. As we move more towards ids as a best practice we would like these adapters to handle overrides more elegantly.

We have created the Overrider class that handles both symbol->symbol and symbol->id overrides. It was added to Coingecko and Coinpaprika, but there are other adapters that could utilize it.

Acceptance Criteria

  1. Identify External Adapters that accept ids or cids in input parameters (e.g. Coinmarketcap)
  2. Implement the Overrider from the EA framework to handle symbol -> id overrides for each of these EAs.

@KuphJr will be able to help provide an introduction on the Overrider feature.

justinkaseman avatar Jun 14 '22 02:06 justinkaseman

High priority adapters:

  • nomics
  • coinmarketcap

justinkaseman avatar Jun 30 '22 15:06 justinkaseman