chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Remove redundant/inaccurate hint in OCR / OCR2 error messages

Open reductionista opened this issue 3 years ago • 3 comments

The peer wrapper will report exactly why it failed to start. No need to guess why later when OCR2 is trying to start.

In the case of OCR, it may or may not be the right guess. In the case of OCR2 it will almost always be the wrong guess. (The peer wrapper might fail to start if it's configured to use v1, but that has nothing to do with OCR2. If OCR2 is enabled, it's more likely due to one of the v2 env vars not being set, since that's the only protocol it uses.)

Either way, the real reason for failure, including the name of the variable they need to set, is already reported by the peer wrapper itself when it tries to start. So even when this guess is right, it's redundant.

reductionista avatar Sep 19 '22 23:09 reductionista

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Sep 19 '22 23:09 github-actions[bot]

Solana Smoke Test Results

1 tests   1 :heavy_check_mark:  4m 42s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit d6e188d8.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]

EVM Smoke Test Results

66 tests   31 :heavy_check_mark:  6m 25s :stopwatch:   1 suites  35 :zzz:   1 files      0 :x:

Results for commit d6e188d8.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]