chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Add dynamic callback fee to VRFV2Wrapper for EIP 150

Open vreff opened this issue 3 years ago • 3 comments

This change adds a dynamic gas fee to the VRFV2Wrapper, so that the low level call() made by the wrapper can be fulfilled on a high callback gas limit.

  • A new function called getEip150Fee is added and used in the contract. This function adds an extra gas / 64 to the wrapper callback gas limit, as to account for the dynamic fee on the second callWithExactGas it uses.
  • The go wrappers are updated.
  • The integration pass that fails for a high callback gas limit fulfillment for the wrapper now passes.

vreff avatar Aug 03 '22 16:08 vreff

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Aug 03 '22 16:08 github-actions[bot]

Solana Smoke Test Results

1 tests   1 :heavy_check_mark:  4m 21s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit 15430d91.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 03 '22 16:08 github-actions[bot]

EVM Smoke Test Results

52 tests   22 :heavy_check_mark:  6m 8s :stopwatch:   1 suites  30 :zzz:   1 files      0 :x:

Results for commit 15430d91.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 03 '22 16:08 github-actions[bot]