chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Published 20 hours ago • verified publisher icon smartcontractkit

Move view functions from proxy to logic

Open infiloop2 opened this issue 2 years ago • 1 comments

This PR tries to move rest of the view functions behind proxy. Solidity does not allow view functions to have delegate calls inside them.

The cleanest way I could make it work, is to make those functions non view, while keeping them as view on logic contract. This also meant that our interface need to be duplicate which is not ideal.

Contract size after this PR: Existing dev registry: 23.99Mb Registry after this refactor: 22.57Mb

So this PR helps in reducing size by 1.42Mb

infiloop2 avatar Jul 21 '22 16:07 infiloop2

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Jul 21 '22 16:07 github-actions[bot]