go 1.19

[jmank88]

Upgrade to go 1.19. Officially released as of August 2nd.

Most of the CI workflows use the version defined in the go.mod files now, so this type of upgrade is much easier.

Versions

1. Trying out 1.19.0-rc.2 https://groups.google.com/g/golang-announce/c/czoG5UpT0EU https://groups.google.com/g/golang-dev/c/4xsD_D5oflI
2. Updated with release: https://groups.google.com/g/golang-announce/c/hwjGDuSVZJo/m/oEuVypt1BAAJ

[github-actions[bot]]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[github-actions[bot]]

EVM Smoke Test Results

61 tests   31 :heavy_check_mark:  6m 26s :stopwatch:   1 suites  30 :zzz:   1 files      0 :x:

Results for commit 72e01309.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Solana Smoke Test Results

1 tests   1 :heavy_check_mark:  4m 41s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit 72e01309.

:recycle: This comment has been updated with latest results.

[jmank88]

@kalverra Any idea what is happening here in the smoke tests with go 1.19?

 Unexpected error:
      <*errors.errorString | 0xc000276b10>: {
          s: "key not found: chainlink-0:0 remaining keys: [chainlink-0:0 node access]",
      }
      key not found: chainlink-0:0 remaining keys: [chainlink-0:0 node access]
  occurred
  In [It] at: /home/runner/work/chainlink/chainlink/integration-tests/smoke/vrfv2_test.go:74

  Full Stack Trace
    github.com/smartcontractkit/chainlink/integration-tests/smoke.glob..func7.2(0x352d120, 0x0?)
    	/home/runner/work/chainlink/chainlink/integration-tests/smoke/vrfv2_test.go:74 +0x2f8
    reflect.Value.call({0x1add220?, 0xc00062efc0?, 0x13?}, {0x1e7fe76, 0x4}, {0xc00028cff0, 0x2, 0x2?})
    	/opt/hostedtoolcache/go/1.19.0/x64/src/reflect/value.go:584 +0x8c5
    reflect.Value.Call({0x1add220?, 0xc00062efc0?, 0x2516f30?}, {0xc00028cff0?, 0x0?, 0x0?})
    	/opt/hostedtoolcache/go/1.19.0/x64/src/reflect/value.go:368 +0xbc

https://github.com/smartcontractkit/chainlink/runs/8114819019?check_suite_focus=true#step:5:316

[kalverra]

Not sure, but I set my own PR to update all the tests to 1.19 as well and that is working fine. Perhaps there is some incompatibility along the pipeline when only upgrading part of it? Worth trying with that PR.

[jmank88]

Not sure, but I set my own PR to update all the tests to 1.19 as well and that is working fine. Perhaps there is some incompatibility along the pipeline when only upgrading part of it? Worth trying with that PR.

rebased and it passed :shrug: I thought it was consistently failing before, but maybe it was fluke(s) and/or changes :thinking: