[CRE-1155] do not validate our internal inputs

[Tofel]

[cl-sonarqube-production[bot]]

Quality Gate passed

Issues
0 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[trunk-io[bot]]

     

Flaky Test	Failure Summary	Logs
TestTransferToMCMSToTimelockSolana	The test failed due to a transaction error caused by a program ID mismatch during a Solana contract initialization.	Logs ↗︎
TestFundMCMSignersChangeset_Apply	The test failed without a specific error message, indicating an unspecified issue during the execution of the flaky test.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs

[mchain0]

I'm not so sure this is a great idea. Would be great to put a description with some motivation behind.

[chudilka1]

Hey, @Tofel , what is the rationale behind this decision?

[Tofel]

@chudilka1 and @mchain0: less code, it is not being shipped to external users, so it is fine if we there's an NPE somewhere or out of bond array iteration, we know how to fix it. Also, all these types are used internally and in 99% by me. I don't think these validations ever failed, tbh.