chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

Update EVM to use new Generalized WT

Open silaslenihan opened this issue 9 months ago • 8 comments

This PR includes the previous EVM WT Extraction that was reverted from develop as well as new changes to inject chain-specific code into the Generalized WT, along with expanded tests.

Requires

  • https://github.com/smartcontractkit/chainlink-common/pull/1160
  • https://github.com/smartcontractkit/chainlink-framework/pull/43
  • https://github.com/smartcontractkit/chainlink-evm/pull/24

Supports

silaslenihan avatar Apr 09 '25 23:04 silaslenihan

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

:medal_military: No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

github-actions[bot] avatar Apr 09 '25 23:04 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and a60a0d3e61407a881efb835b85df018fc37c4ef1 (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

19 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAddRemoteChainWithMcms 50% false false false 2 1 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 3m47.31s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestDeployChainContractsChangesetPreload 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 1m2.333333333s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestRMNRemoteCurseWithMCMS 0% false false false 1 0 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 3m14.16s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetOcr3Candidate 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 2m33.183333333s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestTokenAdminRegistryWithMcms 33.3333% false false true 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 4m12.32s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestTransferCCIPToMCMSWithTimelockSolana 50% false false false 2 1 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 2m30s @smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
UnableToAttributePanicToTestPleaseInvestigate 0% true true false 2 0 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana true 0s UNKNOWN
UnableToAttributePanicToTestPleaseInvestigate 0% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/v1_6 true 0s UNKNOWN
TestDeployMCMSWithTimelockV2 20% false false true 5 1 4 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 46.923333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestMCMSSignFireDrillChangeset 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 49.296666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestRenounceTimelockDeployerConfigValidate 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 2.336666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSV2EVM/MCMS_disabled 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 47.076666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSV2Solana/MCMS_disabled 33.3333% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 51.97s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestValidate 0% false false false 1 0 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 47.73s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
UnableToAttributePanicToTestPleaseInvestigate 0% true true false 1 0 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 0s UNKNOWN
TestFundMCMSignersChangeset_VerifyPreconditions 0% false false true 4 0 4 0 github.com/smartcontractkit/chainlink/deployment/common/changeset/solana false 1m14.043333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestTransferToMCMSToTimelockSolana 0% false false true 4 0 4 0 github.com/smartcontractkit/chainlink/deployment/common/changeset/solana false 1m4.793333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestUpdateTimelockDelaySolana_Apply 0% false false true 1 0 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset/solana false 0s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestUpdateTimelockDelaySolana_VerifyPreconditions 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/common/changeset/solana false 1m14.68s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar May 12 '25 22:05 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and b368fada257808db5a849fc09bdefddb495d194e (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestConfig_Marshal/EVM 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 0s Unknown
TestConfig_Marshal/full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 10ms Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar May 28 '25 23:05 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and 58d71e3db64dd64491a2cb38663bd25b3afa982e (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestConfig_Marshal/full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 13.333333ms Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar May 30 '25 16:05 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and 3856bc6889a3f0685c2ff80e064f2af41bae5eac (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestConfig_Marshal/EVM 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 3.333333ms Unknown
TestConfig_Marshal/full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 16.666666ms Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar May 30 '25 17:05 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and 3192fe927fa5e96caa889c1617a7f7f97d70e934 (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestConfig_Marshal/EVM 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 3.333333ms Unknown
TestConfig_Marshal/full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 10ms Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar Jun 03 '25 14:06 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and 8393e23515e49eeafcadcabb178b5a8144a1bb0d (fix/inject-evm-df-decoder).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

3 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestConfig_full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 0s Unknown
Test_generalConfig_LogConfiguration/full 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 10ms Unknown
Test_generalConfig_LogConfiguration/multi-chain 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/chainlink false 10ms Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar Jun 17 '25 15:06 github-actions[bot]

Quality Gate passed Quality Gate passed

Issues
6 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

cl-sonarqube-production[bot] avatar Jun 18 '25 21:06 cl-sonarqube-production[bot]