chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Default configurations for multi-family CCIP utilities.

Open winder opened this issue 8 months ago • 4 comments

Add and use default instantiations of multi-family CCIP utilities to reduce the number of places where all implementations are listed.

This PR simply adds the following, and updates code to use them wherever possible:

// DefaultExtraDataCodec is the default ExtraDataCodec for CCIP initialized with all supported chain families.
var DefaultExtraDataCodec = common.NewExtraDataCodec(
	common.NewExtraDataCodecParams(ccipevm.ExtraDataDecoder{}, ccipsolana.ExtraDataDecoder{}))

// DefaultAddressCodec is the default AddressCodec for CCIP initialized with all supported chain families.
var DefaultAddressCodec = common.NewAddressCodec(
	common.NewAddressCodecParams(
		ccipevm.AddressCodec{},
		ccipsolana.AddressCodec{},
	))

winder avatar Apr 08 '25 13:04 winder

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

:medal_military: No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

github-actions[bot] avatar Apr 08 '25 14:04 github-actions[bot]

If this is just a improvement thing and not needed to be merge immediately, I can have this default config included in my existing refactor PR https://github.com/smartcontractkit/chainlink/pull/16363, it reduces the code and simplifies extraDataCodec

huangzhen1997 avatar Apr 08 '25 16:04 huangzhen1997

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 09 '25 00:06 github-actions[bot]