Added encryptionPublicKey to Keystone NodeInfo DEVSVCS-592
https://smartcontract-it.atlassian.net/browse/DEVSVCS-592
For ST3, each node is to have its own public key so that users can encrypt secrets for that particular node.
In my ChatGPT research, it appears that standard public keys cannot fit into a bytes32 value, so I have opted to use a bytes value instead.
I would appreciate a thoughtful review of this approach!
Static analysis results are available
Hey @KuphJr, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.
Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.
WF: CI Core#3b52f0a
Error: Use of Internal Package Not Allowed
Source of Error:
Core Tests (go_core_ccip_deployment_tests) Run tests 2024-10-08T23:19:50.7681094Z ##[error] deployment/ccip/deploy_home_chain.go:32:2: use of internal package github.com/smartcontractkit/chainlink/v2/core/internal/testutils not allowed
Why: The error is caused by an attempt to import an internal package from a location that is not permitted by Go's package management rules. Internal packages can only be imported by code that is part of the same parent package.
Suggested fix: To resolve this issue, you can either move the importing code to the same parent package as the internal package, or refactor the internal package to be a public package if it needs to be widely accessible.
@KuphJr We're specifically going to be using a Curve25519 key using NaCl (the functions approach), and that does fit into a 32 byte var; can we change it to that?
Quality Gate passed
Issues
3 New issues
0 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.