chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

ChainComponents EVM Interface Tests

Open silaslenihan opened this issue 1 year ago • 2 comments

Description: Changes the ChainReader EVM Interface tests to use the ChainWriter instead of a helper and updates the simulated backend ChainReader tests to implement a TXM + ChainWriter

Corresponding ticket:

Requires Dependencies

  • https://github.com/smartcontractkit/chainlink-common/pull/664

Resolves Dependencies

  • BCI-3498
  • https://github.com/smartcontractkit/chainlink-evm-testing/pull/118

silaslenihan avatar Jul 01 '24 21:07 silaslenihan

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

whats up with the commit history?

I believe Amit's commits are included in this PR because I was dependent on the Finazlier changes he was working on. While those were still in progress I based this branch on his branch. I'm not sure why they are still there though because I rebased on top of develop

silaslenihan avatar Sep 05 '24 13:09 silaslenihan

whats up with the commit history?

I believe Amit's commits are included in this PR because I was dependent on the Finazlier changes he was working on. While those were still in progress I based this branch on his branch. I'm not sure why they are still there though because I rebased on top of develop

HIs commits got squashed so when you rebase it doesn't recognize them

ilija42 avatar Sep 05 '24 14:09 ilija42