chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

[BCI-2953] Initial Aptos keystore

Open yongkangchia opened this issue 1 year ago • 4 comments

Ticket

BCI-2953

Changes:

  • Added Aptos Keystore to Core. This includes Aptos Key which uses ED25519, Keystore, Relevant tests

Note:

  • Config Related changes are pushed to Another ticket as Aptos is still in development stages. Config changes can be made when ready.

yongkangchia avatar Jun 15 '24 02:06 yongkangchia

Don't forget to include https://github.com/smartcontractkit/chainlink/blob/b7f4dc302823a7e2d9ae7f1e836c209d8294bc14/core/services/job/orm.go#L603-L606

archseer avatar Jun 19 '24 02:06 archseer

Don't forget to include https://github.com/smartcontractkit/chainlink/blob/b7f4dc302823a7e2d9ae7f1e836c209d8294bc14/core/services/job/orm.go#L603-L606

thanks for pointing this out. there were some dependencies issues with chainwriter locally so I was planning to either add that in another pr or when all the tests pass.

yongkangchia avatar Jun 19 '24 07:06 yongkangchia

Added tests to validation of configs. However the invalidation tests are currently formatted slightly differently because its just one error.

Now:     - Aptos.0.Enabled: invalid value (1): expected *bool

With more tests:
                                +       - Aptos.0: 2 errors:
                                +                       - Enabled: invalid value (1): expected *bool
                                +                       - test: invalid value (1): this is a test

yongkangchia avatar Jun 28 '24 17:06 yongkangchia