Use Seth EVM client in E2E VRF tests
- [x] Docker tests are passing
- [x] K8s tests are passing https://smartcontract-it.atlassian.net/browse/VRF-1036
- [x] Fix vrf* wasp guns https://github.com/smartcontractkit/chainlink/pull/12964#issuecomment-2107139224
remark - I see that nonce issue was not resolved when rps is set to high value (e.g. 10) in WASP tests
remark - I see that nonce issue was not resolved when rps is set to high value (e.g. 10) in WASP tests
@iljapavlovs is this something that worked fine with the old EVM Client? If yes, that should be fixed in this PR. If not, I suggest not to create a follow up ticket for it. cc @Tofel @skudasov
@iljapavlovs is this something that worked fine with the old EVM Client? If yes, that should be fixed in this PR. If not, I suggest not to create a follow up ticket for it. cc @Tofel @skudasov
EVM Client had the same issue. I still need to dig deep into Sergey's newly added readme, but tbh im not using high rps in my tests
additionally vrf* wasp guns need to rewritten, currently they just call request randomness function from geth wrapper, which uses root address. But this is not thread-safe, so if wasp is spawning goroutines to generate expected RPS some of these transactions will fail.
probably best approach here would be to use
AnySyncedKey()and to pass that to (a new function) calledRequestRandomnessFromKey()
@iljapavlovs how about this one that @Tofel mentioned? Is it needed in this PR? If no, I can create a follow up ticket for it,
additionally vrf* wasp guns need to rewritten, currently they just call request randomness function from geth wrapper, which uses root address. But this is not thread-safe, so if wasp is spawning goroutines to generate expected RPS some of these transactions will fail. probably best approach here would be to use
AnySyncedKey()and to pass that to (a new function) calledRequestRandomnessFromKey()@iljapavlovs how about this one that @Tofel mentioned? Is it needed in this PR?
Yes, that would make sense to be updated in this PR. so this should help with nonce issues
additionally vrf* wasp guns need to rewritten, currently they just call request randomness function from geth wrapper, which uses root address. But this is not thread-safe, so if wasp is spawning goroutines to generate expected RPS some of these transactions will fail. probably best approach here would be to use
AnySyncedKey()and to pass that to (a new function) calledRequestRandomnessFromKey()@iljapavlovs how about this one that @Tofel mentioned? Is it needed in this PR?
Yes, that would make sense to be updated in this PR. so this should help with nonce issues
@iljapavlovs @Tofel ok, let me add a todo to this PR and fix it
@iljapavlovs I updated the wasp/load tests to use AnySyncedKey() from Seth. Please have a look
Quality Gate passed
Issues
8 New issues
5 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
4.4% Duplication on New Code