chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

gas optimizations and minor fixes

Open fbac opened this issue 1 year ago • 2 comments

  • Some variable names are now more representative.
  • Added clarifying comments.
  • _needsFunding gas optimized: Now it requires the caller function to pass minWaitPeriodPassed, saving one SLOAD per execution.
  • setWatchlist gas optimized: Remove s_onRampAddresses members on descending order to save EnumerableMap swapping keys.
  • Return lastTopUpTimestamp as part of getAccountInfo

fbac avatar Feb 23 '24 14:02 fbac

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Feb 23 '24 14:02 github-actions[bot]

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

cl-sonarqube-production[bot] avatar Mar 12 '24 15:03 cl-sonarqube-production[bot]