chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Refactor EVM ORMs

Open DylanTinianov opened this issue 1 year ago • 3 comments

Refactor ORMs to remove dependency on core/services/pg and Q type.

DylanTinianov avatar Jan 25 '24 18:01 DylanTinianov

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Jan 25 '24 18:01 github-actions[bot]

I see that you haven't updated any README files. Would it make sense to do so?

github-actions[bot] avatar Jan 25 '24 18:01 github-actions[bot]

For the error package, take a look at this PR: https://github.com/smartcontractkit/chainlink/pull/11848

dimriou avatar Mar 04 '24 12:03 dimriou

I think we need to wait to merge until we have a way to reproduce the logging and timeout behavior, or until after the 2.10 release is cut.

2.10 has been cut, but let's figure out how to connect these https://github.com/smartcontractkit/chainlink-common/pull/396 to preserve the behavior.

jmank88 avatar Mar 08 '24 14:03 jmank88

core/chains/evm/log NewORM still depends on pg.QConfig - did we want to refactor all uses of that interface out from core/chains/evm/...?

Yes, there's another PR to tackle log and evm TxStore: https://github.com/smartcontractkit/chainlink/pull/12189

DylanTinianov avatar Mar 13 '24 22:03 DylanTinianov

Are we preserving the cases where a long timeout is needed?

I believe there happen to be none in this PR, but the following PRs can make use of WithoutDefaultTimeout to skip the default and include their own.

jmank88 avatar Mar 14 '24 14:03 jmank88