chainlink
chainlink copied to clipboard
Refactor EVM ORMs
Refactor ORMs to remove dependency on core/services/pg and Q type.
I see that you haven't updated any CHANGELOG files. Would it make sense to do so?
I see that you haven't updated any README files. Would it make sense to do so?
For the error package, take a look at this PR: https://github.com/smartcontractkit/chainlink/pull/11848
I think we need to wait to merge until we have a way to reproduce the logging and timeout behavior, or until after the 2.10 release is cut.
2.10 has been cut, but let's figure out how to connect these https://github.com/smartcontractkit/chainlink-common/pull/396 to preserve the behavior.
core/chains/evm/logNewORMstill depends on pg.QConfig - did we want to refactor all uses of that interface out fromcore/chains/evm/...?
Yes, there's another PR to tackle log and evm TxStore: https://github.com/smartcontractkit/chainlink/pull/12189
Are we preserving the cases where a long timeout is needed?
I believe there happen to be none in this PR, but the following PRs can make use of WithoutDefaultTimeout to skip the default and include their own.
Quality Gate passed
Issues
3 New issues
0 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
84.4% Coverage on New Code
0.3% Duplication on New Code