chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

Remove unused file core/services/ocr2/plugins/median/plugin.go

Open reductionista opened this issue 2 years ago • 5 comments

After being moved out of this repo to chainlink-feeds, this was restored accidentally in https://github.com/smartcontractkit/chainlink/commit/c17067b874bebcda72cae8a335d9c6b5fc681f3a

reductionista avatar Dec 09 '23 04:12 reductionista

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Dec 09 '23 04:12 github-actions[bot]

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cl-sonarqube-production[bot] avatar Dec 09 '23 04:12 cl-sonarqube-production[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cl-sonarqube-production[bot] avatar Feb 08 '24 14:02 cl-sonarqube-production[bot]

i see that medIan_test.go was also added in the PR c17067b. should it be removed, too, in this one?

@reductionista let's add this file too

jmank88 avatar Feb 08 '24 17:02 jmank88

Was this change reduced to a no-op?

jmank88 avatar Feb 26 '24 17:02 jmank88