chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

BCI-2376 TXM as service. Post TX endpoint.

Open dhaidashenko opened this issue 2 years ago • 3 comments

Marking it as draft while we are waiting for sec review

  • Added new endpoint that allows users to submit transaction request to TXM. Primary use case for this endpoint is config distribution via Gauntlet++
  • Endpoint requires Admin Role. Additionally it must be enabled via feature flag.

Open questions:

  • Is this tx.FeeLimit = chain.Config().EVM().GasEstimator().LimitDefault() the right way to get FeeLimit?

Issues that are not solved by this PR

  • It's not possible to deploy contract using this endpoint as Txm by design does not allow to set nil toAddress
  • Confirmed transactions are removed from db at some point. Gauntlet++ expects idempotent behavior of the endpoint on provided key. We might endup with duplicated transactions that might lead to unforeseen issues.
  • GET /transactions/evm returns last TxAttempt which might not be the one that is actually included into the chain

dhaidashenko avatar Nov 10 '23 16:11 dhaidashenko

I see that you haven't updated any README files. Would it make sense to do so?

github-actions[bot] avatar Nov 10 '23 16:11 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 29 '24 00:01 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 09 '24 00:04 github-actions[bot]