chainlink
chainlink copied to clipboard
Gas prices Data Source Changes
This PR does the following:
- [x] Updates plugin config to accept optional gas price data source string
- [x] Instantiate a new median factory (both loopp and legacy plugins) with gas price data source
- [x] Updates ORM method to save a median plugin pipeline
Related PRs:
- libocr: adding median gasPrice to ocr reports
- chainlink-relay: update interfaces + serve gasPrice data over loopp
- PR Merge Order (from top to bottom in order)
-
libocr
- NumericalMedianFactory gets changed to have a gas price data source
- Note: (If someone bumps libocr in core, median factory will need to be updated with nil)
- Note: (You will not be able to bump libocr in chainlink-relay until the below PR gets merged)
-
chainlink-relay
- Currently uses the replace directive, once libocr is merged we remove replace directive and bump the version of libocr
- The plugin median interface is updated to include gas price data source
- Begins the grpc service for gas price data source
- Note: (You cannot bump chainlink-relay in chainlink repo until the PR below bets merged)
- chainlink-feeds
-
chainlink
- Uses replace directive for both chainlink-relay and libocr. They should get updated when the respective repos get updated
- Parses TOML config for (optional) gas price data source and passes it into median factory.
-
libocr
I see that you haven't updated any README files. Would it make sense to do so?
retest
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6111856435
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112031805
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112032320
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114674548
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6122503216
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126405294
SonarQube Quality Gate
Maintainability Rating on New Code (is worse than A)
8.21% Technical Debt Ratio on New Code (is greater than 4%)
See analysis details on SonarQube
Fix issues before they fail your Quality Gate with SonarLint in your IDE.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.
SonarQube Quality Gate
Maintainability Rating on New Code (is worse than A)
0.0% Coverage on New Code (is less than 75%)
8.68% Technical Debt Ratio on New Code (is greater than 4%)
See analysis details on SonarQube
Fix issues before they fail your Quality Gate with SonarLint in your IDE.
I assume the Foundry dependency change is not intentional? If not, please undo it.
I assume the Foundry dependency change is not intentional? If not, please undo it.
yeah, it was an artifact of testing unrelated changes. I'll remove it
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.