chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Gas prices Data Source Changes

Open augustbleeds opened this issue 1 year ago • 13 comments

This PR does the following:

  • [x] Updates plugin config to accept optional gas price data source string
  • [x] Instantiate a new median factory (both loopp and legacy plugins) with gas price data source
  • [x] Updates ORM method to save a median plugin pipeline

Related PRs:

  • PR Merge Order (from top to bottom in order)
    1. libocr
      • NumericalMedianFactory gets changed to have a gas price data source
      • Note: (If someone bumps libocr in core, median factory will need to be updated with nil)
      • Note: (You will not be able to bump libocr in chainlink-relay until the below PR gets merged)
    2. chainlink-relay
      • Currently uses the replace directive, once libocr is merged we remove replace directive and bump the version of libocr
      • The plugin median interface is updated to include gas price data source
      • Begins the grpc service for gas price data source
      • Note: (You cannot bump chainlink-relay in chainlink repo until the PR below bets merged)
    3. chainlink-feeds
    4. chainlink
      • Uses replace directive for both chainlink-relay and libocr. They should get updated when the respective repos get updated
      • Parses TOML config for (optional) gas price data source and passes it into median factory.

augustbleeds avatar Sep 05 '23 14:09 augustbleeds

I see that you haven't updated any README files. Would it make sense to do so?

github-actions[bot] avatar Sep 05 '23 14:09 github-actions[bot]

retest

augustbleeds avatar Sep 05 '23 16:09 augustbleeds

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6111856435

github-actions[bot] avatar Sep 07 '23 15:09 github-actions[bot]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112031805

github-actions[bot] avatar Sep 07 '23 15:09 github-actions[bot]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112032320

github-actions[bot] avatar Sep 07 '23 15:09 github-actions[bot]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114674548

github-actions[bot] avatar Sep 07 '23 20:09 github-actions[bot]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6122503216

github-actions[bot] avatar Sep 08 '23 13:09 github-actions[bot]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126405294

github-actions[bot] avatar Sep 08 '23 21:09 github-actions[bot]

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)
Failed condition 8.21% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 18 '23 00:11 github-actions[bot]

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)
Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)
Failed condition 8.68% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

I assume the Foundry dependency change is not intentional? If not, please undo it.

RensR avatar Jan 22 '24 16:01 RensR

I assume the Foundry dependency change is not intentional? If not, please undo it.

yeah, it was an artifact of testing unrelated changes. I'll remove it

augustbleeds avatar Feb 08 '24 17:02 augustbleeds

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 09 '24 00:04 github-actions[bot]