chainlink-testing-framework icon indicating copy to clipboard operation
chainlink-testing-framework copied to clipboard

[TT-1519][TT-1524] new deployer support

Open Tofel opened this issue 1 year ago • 1 comments


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes correct misspellings, refactor code for clarity, improve test setup, and ensure consistent naming conventions across various components related to Ethereum blockchain testing and deployment. Specifically, these modifications address inaccuracies in type names, enhance logging and testing capabilities, and streamline configuration management for better maintainability and readability.

What

  • lib/concurrency/example_test.go
    • Corrected spelling mistakes from ContractIntstance to ContractInstance.
  • lib/docker/test_env/besu_base.go, besu_eth1.go, besu_eth2.go, erigon_base.go, erigon_eth1.go, erigon_eth2.go, geth_base.go, geth_eth1.go, geth_eth2.go, nethermind_base.go, nethermind_eth1.go, nethermind_eth2.go, prysm.go, reth_base.go, reth_eth2.go
    • Removed unused imports and commented out unnecessary logger and testing fields, improving code readability.
  • lib/docker/test_env/env_component.go, env_component_test.go
    • Introduced new functional options for setting test instances and logger directly in environment components, enhancing test flexibility and configuration clarity.
  • lib/docker/test_env/ethereum_env.go
    • Added new EthereumNetworkHooks interface and included hooks in the Ethereum network builder to allow for custom pre-start and post-start actions, enhancing extensibility.
  • seth/client_builder.go
    • Added a new method NewClientBuilderWithConfig to initialize a client builder with an existing config, offering more versatility in client configuration.
    • Added BuildConfig method to return the config directly from the builder, providing direct access to the constructed configuration.

Tofel avatar Sep 05 '24 17:09 Tofel

Quality Gate failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

no longer needed

Tofel avatar Oct 23 '24 11:10 Tofel