chainlink-starknet icon indicating copy to clipboard operation
chainlink-starknet copied to clipboard

bump juno to v0.12.2

Open jmank88 opened this issue 1 year ago • 3 comments

jmank88 avatar Sep 16 '24 19:09 jmank88

Thanks, is this just cause? Or is there some dependency in the core that requires this bump

augustbleeds avatar Sep 16 '24 21:09 augustbleeds

Thanks, is this just cause? Or is there some dependency in the core that requires this bump

I was hoping this would have a cascading effect that fixes the sourcegraph issues, but starknet.go is not compatible with this version anyways.

jmank88 avatar Sep 16 '24 21:09 jmank88

@jmank88 Nethermind recently made a code change to update starknet.go based off our request to bump juno.

https://github.com/NethermindEth/starknet.go/pull/625

They said it'll be released in their next version

augustbleeds avatar Sep 26 '24 18:09 augustbleeds

Updated to the latest starknet.go version, but now this forces us to upgrade geth, so we're blocked on https://github.com/smartcontractkit/chainlink/pull/11809.

jmank88 avatar Oct 10 '24 17:10 jmank88

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Why was this closed? Please re-open @chray-zhang

jmank88 avatar Nov 26 '24 00:11 jmank88

@jmank88

I accidentally erased some of chainlink-starknet's origin history. Do you have a local branch you can force push up? If not I created a new PR with your commit: https://github.com/smartcontractkit/chainlink-starknet/pull/555

Can you let me know if that's the change?

chray-zhang avatar Nov 26 '24 00:11 chray-zhang

@jmank88

I accidentally erased some of chainlink-starknet's origin history. Do you have a local branch you can force push up? If not I created a new PR with your commit: #555

Can you let me know if that's the change?

That is probably good enough :+1:

jmank88 avatar Nov 26 '24 00:11 jmank88