Alec Hammond

Vector fields docs

1

Would be good to add a simple page in the docs that describe how fmmax computes vector fields. The paper describes this to some detail, but even since then, fmmax...

Alternate BZ grid generation for better resource utilization

1

Currently, the [`brillouin_zone_in_plane_wavevector()`](https://github.com/facebookresearch/fmmax/blob/8c7491a23e902644614c1761b6fbefa472786567/src/fmmax/basis.py#L191) function samples a uniform grid of BZ points by building an `(N,M)` grid, and sampling the centers of each sub region. This approach requires `NxM` points. This...

Now that fmmax has some updated vector field formulations, it would be good to rerun some longer, more exhaustive tests just to ensure things are as we expect. Here are...

Normally, near2far transformations within RCWA/FMM codes are really straightforward. All you have to do is propagate your fields until you hit a uniform, homogenous layer. Once you hit that layer,...

Visualization routines

2

It might be nice to add some visualization routines. In theory, this should be really straightforward, especially since everything is defined later by layer. But there are many ways one...

Document batch conventions

4

In the `README.md`, we talk about fmmax's ability to batch over operations. But it would be good to discuss exactly how the user should provide the arrays such that they...

Augment microlens array example to include conformal AR coating

1

It would be interesting (and probably difficult) to modify the microlens array example to include a *conformal* AR coating. This is particularly important when the index contrast is particularly high,...

Batching with pmap

1

Currently, FMMAX performs a lot of broadcasting under the hood, such that it's easy to simulate a device over multiple wavelength points and/or multiple k-points (all of which are completely...

Currently, if the `wavelength` parameter within `eigensolve_isotropic_media` is passed as a `float`, rather than a jax array, then it throws an obscure error (not directly pointing to the `wavelength` parameter...

Would be good to export the API docstrings into some documentation. The examples could be exported too (even better would be to export notebooks with the accompanying text explaining things).